Embedded key loader #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
demonsh
commented
Dec 26, 2024
demonsh
commented
- NewEmbeddedKeyLoader with embedded verification keys for:
- authV2.json
- credentialAtomicQueryMTPV2.json
- credentialAtomicQueryMTPV2OnChain.json
- credentialAtomicQuerySigV2.json
- credentialAtomicQuerySigV2OnChain.json
- credentialAtomicQueryV3-beta.1.json
- credentialAtomicQueryV3OnChain-beta.1.json
- linkedMultiQuery10-beta.1.json
- Updated readme
- added configuration for NewEmbeddedKeyLoader - added examples for supported networks - minor improvements and links to the resources added
demonsh
requested review from
olomix,
OBrezhniev,
ilya-korotya and
vmidyllic
olomix
approved these changes
Jan 2, 2025
| } | ||
| return key, nil | ||
| } | ||
| slog.Warn("failed to load key from custom loader", "circuit_id", id, "error", err) |
There was a problem hiding this comment.
Hm... If the user of the library explicitly provides the custom key loader, I suppose he definitely wants to use keys from this key loader. Not the embedded ones. In this case I would expect to return the error here instead of just returning embedded keys with warning.
| @@ -0,0 +1,104 @@ | |||
| { | |||
There was a problem hiding this comment.
What do you think about renaming the loaders/keys directory to loaders/verification_keys? I didn’t immediately understand the purpose of these JSON files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.